Firing click listeners is without doing a server side roundtrip

vaadin / vaadin-button-flow

Vaadin Flow Java API for vaadin/vaadin-button Web Component

https://vaadin.com/components/vaadin-button

Other

0 stars 7 forks source link

Firing click listeners is without doing a server side roundtrip #94

Closed mstahv closed 5 years ago

mstahv commented 5 years ago

closes #67

This change is

CLAassistant commented 5 years ago

All committers have signed the CLA.

mstahv commented 5 years ago

To me firing events sounds like normal developer jargon, but as you wish. I'll modify the change a bit.

denis-anisimov commented 5 years ago

To me firing events sounds like normal developer jargon, but as you wish. I'll modify the change a bit.

It's definitely a normal jargon.

The problem is that the click method executed via JS is something more than firing an event. So the method name is confusing since it does something else.

As a side note: fireXXX methods are not normally exposed as public. They should be private methods which are not visible to the end developer. There always should be a meaningful action which changes a state and as a result fires an event about this state change.

denis-anisimov commented 5 years ago

There are merge conflicts that need to be resolved.

vaadin-bot commented 5 years ago

SonarQube analysis reported 2 issues

Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

Button.java#L41: Remove this unused "THEME_ATTRIBUTE" private field.
Button.java#L50: Remove this unused "disableListener" private field.