search

vaadin / vaadin-combo-box-flow

Vaadin Flow Java API for vaadin/vaadin-combo-box Web Component
https://vaadin.com/components/vaadin-combo-box
Other
5 stars 9 forks source link

Add add-method call to make code complete #346

Closed anasmi closed 4 years ago

anasmi commented 4 years ago

For users to be able to use code correctly by copy-pasting Depends on https://github.com/vaadin/flow/pull/8199/files

CLAassistant commented 4 years ago

CLA assistant check
All committers have signed the CLA.

vaadin-bot commented 4 years ago

SonarQube analysis reported 9 issues

Watch the comments in this conversation to review them.

7 extra issues

Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

  1. CRITICAL ComboBoxView.java#L57: Make "projectData" transient or serializable. rule
  2. CRITICAL ComboBoxView.java#L83: Define a constant instead of duplicating this literal "Option two" 9 times. rule
  3. CRITICAL ComboBoxView.java#L83: Define a constant instead of duplicating this literal "Option one" 9 times. rule
  4. CRITICAL ComboBoxView.java#L84: Define a constant instead of duplicating this literal "Label" 3 times. rule
  5. CRITICAL ComboBoxView.java#L401: Define a constant instead of duplicating this literal "Center" 4 times. rule
  6. CRITICAL ComboBoxView.java#L401: Define a constant instead of duplicating this literal "Right" 4 times. rule
  7. CRITICAL ComboBoxView.java#L403: Define a constant instead of duplicating this literal "theme" 4 times. rule
alvarezguille commented 4 years ago

This should be cherry-picked to 3.1 branch so that it's not lost once 3.1 is in Vaadin 14.3

anasmi commented 4 years ago

Closing in favor of https://github.com/vaadin/vaadin-combo-box-flow/pull/351