search

vaadin / vaadin-combo-box

The Web Component for displaying a list of items with filtering. Part of the Vaadin components.
https://vaadin.com/components
Apache License 2.0
115 stars 85 forks source link

fix: prevent initial validation when the field is initialized as invalid #1039

Closed roastedcpu closed 1 year ago

roastedcpu commented 1 year ago

Backports web-components#4172 as part of an EoD task

Description

This PR adds unit tests verifying that no initial validation happens for combo-box.

Part of #4150

Type of change

  • [x] Internal

Checklist

  • [x] I have read the contribution guide: https://vaadin.com/docs-beta/latest/guide/contributing/overview/
  • [x] I have added a description following the guideline.
  • [x] The issue is created in the corresponding repository and I have referenced it.
  • [x] I have added tests to ensure my change is effective and works as intended.
  • [x] New and existing tests are passing locally with my change.
  • [x] I have performed self-review and corrected misspellings.

Additional for Feature type of change

  • [ ] Enhancement / new feature was discussed in a corresponding GitHub issue and Acceptance Criteria were created.