search

vaadin / vaadin-context-menu

The responsive Web Component for showing context dependent items for any element on the page. Part of the Vaadin components.
https://vaadin.com/components
Apache License 2.0
26 stars 10 forks source link

Fix: submenu display inside so much on parent menu #262

Closed Harry-Ph closed 4 years ago

Harry-Ph commented 4 years ago

Fixed sub-menu displays (left side of its parent menu)so much inside its parent menu if comparison with sub-menu displays on the right side of its parent menu.

Fixed by getting x coordinate = the left parent - the width of content of sub-menu - the space (left) between menu content and parent-overlay.

Fixes #261

Haprog commented 4 years ago

@web-padawan @hongduc-phan since this PR was closed, the issue should be moved out of In Review to somewhere else. If one of you is working on this, please check assignment and move to In Progress (or if not, then somewhere else?)

web-padawan commented 4 years ago

I investigate the proper fix and it doesn't seem straightforward but hope to get it done tomorrow.

web-padawan commented 4 years ago

I prototyped a possible fix in #264 but it needs to be double checked.

@hongduc-phan can you please take a look at my PR? If you find that it works, can you apply this change and add the tests?

Harry-Ph commented 4 years ago

I prototyped a possible fix in #264 but it needs to be double checked.

@hongduc-phan can you please take a look at my PR? If you find that it works, can you apply this change and add the tests?

yes, I will check it and correct the test if needed. Thank Serhii.