search

vaadin / vaadin-context-menu

The responsive Web Component for showing context dependent items for any element on the page. Part of the Vaadin components.
https://vaadin.com/components
Apache License 2.0
26 stars 10 forks source link

A fix for https://github.com/vaadin/vaadin-context-menu/issues/280 . #281

Closed enver-haase closed 3 years ago

enver-haase commented 3 years ago

This allows a user to set the 'aria-haspopup' attribute for a context menu item without it being overridden by Vaadin's code when there is no child menu item.

CLAassistant commented 3 years ago

CLA assistant check
All committers have signed the CLA.

tomivirkki commented 3 years ago

Thanks for the PR. Could use a test.

web-padawan commented 3 years ago

It has been a while since this PR was submitted. Apologies about keeping it open for so long without any progress.

The component has been converted to Polymer 3 so there is a merge conflict. Also, the new development for Vaadin web components will happen in the monorepo.

One more thing: there is an accessibility review for our components going on. After that is done, we will prioritise all the accessibility-related issues (most likely, including this one).

I'm closing this now. We will submit a new PR to the monorepo when the linked issue is prioritised.