search

vaadin / vaadin-date-picker-flow

Vaadin Flow Java API for vaadin/vaadin-date-picker Web Component
https://vaadin.com/components/vaadin-date-picker
Other
1 stars 11 forks source link

fix: date selection very broken on Safari in some conditions #190

Closed Haprog closed 5 years ago

Haprog commented 5 years ago

Fixes #126

This change is Reviewable

CLAassistant commented 5 years ago

CLA assistant check
All committers have signed the CLA.

Haprog commented 5 years ago

This seems to work fine on Chrome, Firefox, Safari 12, Edge, IE11, iOS 12.2 and iOS 11.3.

But for some reason whole date picker overlay layout is broken on iOS 9.3 Safari and there are some JS errors preventing date picker from working at all in iOS 10.3.1 Safari. These should be investigated before merging though I'm not sure now if those are caused by this PR or were they already happening in master.

Haprog commented 5 years ago

The iOS 9.3 Safari layout issue seems to be a bug in vaadin-date-picker. It seems that vaadin-date-picker overlay layout is completely broken in Safari 9 since vaadin-date-picker v3 (it still works in latest v2.x). I'll open a new issue about that.

Haprog commented 5 years ago

I tried running the Flow demos again and testing on iOS 10.3.1 Safari and seems to be working fine at least when running in production mode, so this PR should be fine and working good in all tested browsers.