search

vaadin / vaadin-date-picker-flow

Vaadin Flow Java API for vaadin/vaadin-date-picker Web Component
https://vaadin.com/components/vaadin-date-picker
Other
1 stars 11 forks source link

Server side validation #197

Closed tulioag closed 5 years ago

tulioag commented 5 years ago

This change is Reviewable

CLAassistant commented 5 years ago

CLA assistant check
All committers have signed the CLA.

vaadin-bot commented 5 years ago

SonarQube analysis reported 16 issues

Watch the comments in this conversation to review them.

Top 10 extra issues

Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

  1. MINOR DatePickerValidationPage.java#L32: Make this final field static too. rule
  2. MINOR DatePickerValidationPage.java#L32: Rename this field "STATUS" to match the regular expression '^[a-z][a-zA-Z0-9]*$'. rule
  3. MINOR DatePickerValidationPage.java#L33: Make this final field static too. rule
  4. MINOR DatePickerValidationPage.java#L33: Rename this field "VALUE" to match the regular expression '^[a-z][a-zA-Z0-9]*$'. rule
  5. MINOR DatePickerValidationPage.java#L32: Make this final field static too. rule
  6. MINOR DatePickerValidationPage.java#L32: Rename this field "STATUS" to match the regular expression '^[a-z][a-zA-Z0-9]*$'. rule
  7. MINOR DatePickerValidationPage.java#L33: Make this final field static too. rule
  8. MINOR DatePickerValidationPage.java#L33: Rename this field "VALUE" to match the regular expression '^[a-z][a-zA-Z0-9]*$'. rule
  9. MINOR DatePicker.java#L55: Reorder the modifiers to comply with the Java Language Specification. rule
  10. MINOR DatePicker.java#L55: Remove useless curly braces around statement and then remove useless return keyword rule