search

vaadin / vaadin-date-picker-flow

Vaadin Flow Java API for vaadin/vaadin-date-picker Web Component
https://vaadin.com/components/vaadin-date-picker
Other
1 stars 11 forks source link

[2.0] Fix connector to work with years before 1000 #236

Closed Haprog closed 4 years ago

Haprog commented 4 years ago

Cherry-picked from master (3.1 alpha) without the TestBench API improvement. Fixes #184 for the 2.0 branch.

vaadin-bot commented 4 years ago

SonarQube analysis reported 8 issues

Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

  1. CRITICAL DatePickerViewDemoPage.java#L38: Add a nested comment explaining why this method is empty, throw an UnsupportedOperationException or complete the implementation. rule
  2. CRITICAL DatePickerViewDemoPage.java#L159: Define a constant instead of duplicating this literal "No date is selected" 3 times. rule
  3. CRITICAL DatePickerViewDemoPage.java#L168: Refactor this method to reduce its Cognitive Complexity from 18 to the 15 allowed. rule
  4. CRITICAL DatePickerViewDemoPage.java#L38: Add a nested comment explaining why this method is empty, throw an UnsupportedOperationException or complete the implementation. rule
  5. CRITICAL DatePickerViewDemoPage.java#L159: Define a constant instead of duplicating this literal "No date is selected" 3 times. rule
  6. CRITICAL DatePickerViewDemoPage.java#L168: Refactor this method to reduce its Cognitive Complexity from 18 to the 15 allowed. rule
  7. MAJOR DatePickerViewDemoPage.java#L197: Reduce this lambda expression number of lines from 21 to at most 20. rule
  8. MAJOR DatePickerViewDemoPage.java#L197: Reduce this lambda expression number of lines from 21 to at most 20. rule