vaadin / vaadin-date-picker

The Web Component providing a date selection field with scrollable month calendar. Part of the Vaadin components.
https://vaadin.com/components
Apache License 2.0
165 stars 78 forks source link

Add autoOpenDisabled property #694

Closed niiyeboah closed 4 years ago

niiyeboah commented 4 years ago

When datePicker.autoOpenDisabled = true:

web-padawan commented 4 years ago

@jouni do you have an idea how this should behave, keeping #434 in mind?

web-padawan commented 4 years ago

Note, potential workaround would be to check for _noInput.

tomivirkki commented 4 years ago

The feature design document we agreed upon states that "Mobile UX should stay as it is"

tomivirkki commented 4 years ago

Ping @niiyeboah, the build is red

niiyeboah commented 4 years ago

If you type the value to the field and blur, it's always marked as invalid:

This should be fixed now

tomivirkki commented 4 years ago

esc and enter buttons behave strangely with the new feature:

If you haven't yet opened the dropdown and type a value without opening the dropdown:

If you have opened and closed the dropdown earlier and type a value without opening the dropdown:

tomivirkki commented 4 years ago

If you input a value to a date picker and focus another one, you enter some kind of an eternal loop on IE11: Kapture 2020-02-18 at 17 12 57

Please test the feature on all supported browsers

niiyeboah commented 4 years ago

Rebased and refactored the implementation. Apologies for not testing all browsers 😞

web-padawan commented 4 years ago

@yuriy-fix let me request your review as you have recently changed validation logic.

tomivirkki commented 4 years ago

If I select a value and press esc, the input value is set as the ISO value of the component....and then blurring the field will make it invalid

dp-aod-esc

web-padawan commented 4 years ago

@yuriy-fix @tomivirkki updated validation logic and added tests. PTAL when you have time.