vaadin / vaadin-gradle-plugin

Gradle plugin for Vaadin 14 applications. Takes care of front-end build, helps to configure repositories and to create various project and file templates.
Apache License 2.0
31 stars 9 forks source link

Calling Project.afterEvaluate on an evaluated project has been deprecated. #80

Closed longkerdandy closed 4 years ago

longkerdandy commented 4 years ago

Desktop (please complete the following information):

Describe the bug With Gradle 6.5.1 I got a warning everytime build the project. After investigation it related to Project.afterEvaluate on an evaluated project has been deprecated.

Once a project is evaluated, Gradle ignores all configuration passed to Project#afterEvaluate and emits a deprecation warning. This scenario will become an error in Gradle 7.0.

mvysny commented 4 years ago

Hi, I am unable to reproduce the message on my example project: https://github.com/mvysny/karibu10-helloworld-application . It uses a newer version of the Plugin: 0.8.0. Could you please try out the karibu10-helloworld-application whether the warning is printed as well?

longkerdandy commented 4 years ago

Hi, I have created a demo project to reproduct the warn: https://github.com/longkerdandy/vaadin-gradle-test It seems the warning message comes from the gretty plugin

mvysny commented 4 years ago

Thank you. For a multi-module project the recommended way is to declare the plugin in the root module but not apply it in the root project: please see https://github.com/vaadin/vaadin-gradle-plugin#multi-project-builds for more details.

That being said, I'm not a Gradle expert: in case the documentation feels odd, or if the gradle plugins should generally be able to be applied in subprojects as you suggest, just let me know and I'll take a look at the issue.

mvysny commented 4 years ago

@longkerdandy since you mentioned that the warning actually comes from the Gretty plugin, that leads me to believe that the problem is not present in the Vaadin Gradle Plugin itself. Therefore I'm closing this bug report as invalid; please feel free to reopen if need be.

Could you also please consider opening a bug report at https://github.com/gretty-gradle-plugin/gretty regarding this issue?