search

vaadin / vaadin-grid-flow

Vaadin Flow Java API for vaadin/vaadin-grid Web Component
https://vaadin.com/components/vaadin-grid
Other
14 stars 16 forks source link

Rework filtering example #1076

Closed anasmi closed 4 years ago

anasmi commented 4 years ago

Fixes #921 #842

vaadin-bot commented 4 years ago

SonarQube analysis reported 50 issues

Watch the comments in this conversation to review them.

Top 10 extra issues

Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

  1. CRITICAL GridDemo.java#L2295: Make "draggedItems" transient or serializable. rule
  2. CRITICAL GridDemo.java#L2296: Make "draggedItem" transient or serializable. rule
  3. MAJOR GridDemo.java#: This file has 2,065 lines, which is greater than 750 authorized. Split it into smaller files. rule
  4. MAJOR GridDemo.java#L128: Constructor has 8 parameters, which is greater than 7 authorized. rule
  5. MAJOR GridDemo.java#L253: Define and throw a dedicated exception instead of using a generic one. rule
  6. MAJOR GridDemo.java#L814: Remove this useless assignment to local variable "ageColumn". rule
  7. MAJOR GridDemo.java#L1402: Extract the assignment out of this expression. rule
  8. MAJOR GridDemo.java#L1403: Extract the assignment out of this expression. rule
  9. MAJOR GridDemo.java#L1404: Extract the assignment out of this expression. rule
  10. MAJOR GridDemo.java#L1405: Extract the assignment out of this expression. rule