vaadin / vaadin-grid

vaadin-grid is a free, high quality data grid / data table Web Component. Part of the Vaadin components.
https://vaadin.com/components
Apache License 2.0
399 stars 155 forks source link

Vaadin-grid doesn't work with Vaadin 10.0.0.alpha9 and fails with `grid._createPropertyObserver is not a function` #1152

Closed mvysny closed 6 years ago

mvysny commented 6 years ago

Description

Vaadin-grid doesn't work with Vaadin 10.0.0.alpha9 and fails with grid._createPropertyObserver is not a function. By including the com.vaadin:vaadin:10.0.0.alpha9 dep into the project the com.vaadin:vaadin-grid-flow:1.0.0.alpha3 is added on the classpath; by adding bower dependency of "vaadin-core": "v10.0.0-alpha9" the "_target": "4.1.0-alpha1" grid element is added to bower_components (yup I'm not using webjars nor vaadin bom).

Expected outcome

Grid should just work. It works with vaadin:10.0.0.alpha8.

Actual outcome

Grid fails with grid._createPropertyObserver is not a function in the JavaScript console.

Live Demo

Steps to reproduce

  1. Clone https://github.com/mvysny/karibu-dsl
  2. Edit build.gradle and use ext.vaadin10_version = '10.0.0.alpha9'
  3. Replace @InternalContainerAnnotationForConvert with @Convert.Container in ReviewsList.kt
  4. ./gradlew build
  5. ./gradlew example-v10:appRun
  6. Browse locahost:8080 and go to the reviews tab.

Browsers Affected

mvysny commented 6 years ago

screenshot from 2017-12-12 10-29-07

mvysny commented 6 years ago

Tried to upgrade vaadin-grid element to 4.1.0-alpha2, the issue persists.

tomivirkki commented 6 years ago

Please report in the correct repository (Flow). Vaadin-grid works fine by itself so there's something wrong in the integration.

jouni commented 6 years ago

Heh, the correct repository is actually vaadin-grid-flow, not the Flow repo directly.