search

vaadin / vaadin-time-picker-flow

Vaadin Flow Java API for vaadin/vaadin-time-picker Web Component
https://vaadin.com/components/vaadin-time-picker
Other
6 stars 11 forks source link

Add Helper API #101

Closed anasmi closed 4 years ago

anasmi commented 4 years ago

Current PR has a client-side error: vaadin-item has been already defined

Fixes https://github.com/vaadin/vaadin-time-picker-flow/issues/96

CLAassistant commented 4 years ago

CLA assistant check
All committers have signed the CLA.

vaadin-bot commented 4 years ago

SonarQube analysis reported 24 issues

Watch the comments in this conversation to review them.

Top 10 extra issues

Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

  1. MINOR TimePickerView.java#L286: Reorder the modifiers to comply with the Java Language Specification. rule
  2. MINOR TimePickerView.java#L289: Make this value-based field transient so it is not included in the serialization of this class. rule
  3. MINOR TimePickerView.java#L290: Make this value-based field transient so it is not included in the serialization of this class. rule
  4. MINOR TimePickerView.java#L325: Remove this use of "executeJavaScript"; it is deprecated. rule
  5. MINOR TimePickerView.java#L329: Remove this use of "executeJavaScript"; it is deprecated. rule
  6. MINOR TimePickerPage.java#L106: Remove this use of "setMin"; it is deprecated. rule
  7. MINOR TimePickerPage.java#L107: Remove this use of "setMax"; it is deprecated. rule
  8. MINOR TimePickerPage.java#L106: Remove this use of "setMin"; it is deprecated. rule
  9. MINOR TimePickerPage.java#L107: Remove this use of "setMax"; it is deprecated. rule
  10. MINOR GeneratedVaadinTimePicker.java#L26: Remove this unused import 'com.vaadin.flow.component.Synchronize'. rule