search

vaadin / vaadin-time-picker-flow

Vaadin Flow Java API for vaadin/vaadin-time-picker Web Component
https://vaadin.com/components/vaadin-time-picker
Other
6 stars 11 forks source link

Refactor the project into multiple modules #14

Closed pleku closed 5 years ago

pleku commented 5 years ago

Pins webjar versions in component project. Updates versions to most latest ones (except vaadin-text-field). Uses Flow 1.3-SNAPSHOT and component-base 1.3.0-SNAPSHOT. Adds TestBench Element API and refactores ITs to use that. Bumps version to 1.1-SNAPSHOT

Part of vaadin/flow-component-base#117

This change is Reviewable

pleku commented 5 years ago

Do not squash commits when merging!

vaadin-bot commented 5 years ago

SonarQube analysis reported 10 issues

Watch the comments in this conversation to review them.

5 extra issues

Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

  1. MINOR TimePickerLocalizationView.java#L32: Remove this unused import 'java.time.temporal.ChronoUnit'. rule
  2. MINOR TimePickerLocalizationView.java#L33: Remove this unused import 'java.time.temporal.TemporalUnit'. rule
  3. MINOR TimePickerLocalizationView.java#L34: Remove this unused import 'java.util.Arrays'. rule
  4. MINOR TimePickerLocalizationView.java#L36: Remove this unused import 'java.util.concurrent.TimeUnit'. rule
  5. MINOR TimePickerLocalizationView.java#L63: Remove useless curly braces around statement and then remove useless return keyword rule