search

vaadin / vaadin-time-picker-flow

Vaadin Flow Java API for vaadin/vaadin-time-picker Web Component
https://vaadin.com/components/vaadin-time-picker
Other
6 stars 11 forks source link

NPE if no locale is selected in component demo #17

Closed paulroemer closed 5 years ago

paulroemer commented 5 years ago

Steps to reproduce:

  1. https://vaadin.com/components/vaadin-time-picker/java-examples
  2. Use the 'x' to delete the selected locale in "Localized Time Picker" demo

=> page will reload caused by the NPE

Locale must not be null.
  com.vaadin.flow.component.timepicker.demo.TimePickerView.lambda$createLocalizedTimePicker$ea26d33e$1(TimePickerView.java:69)

Used version from V13 beta1

pleku commented 5 years ago

Reopened, see comment https://github.com/vaadin/vaadin-time-picker-flow/pull/18#issuecomment-463652131

fluorumlabs commented 5 years ago

If the demo still needs workaround (see https://github.com/vaadin/vaadin-time-picker-flow/pull/18#issuecomment-463923528), why this issue is closed?