search

vaadin / vaadin-time-picker-flow

Vaadin Flow Java API for vaadin/vaadin-time-picker Web Component
https://vaadin.com/components/vaadin-time-picker
Other
6 stars 11 forks source link

Disallow to clear locale selection #18

Closed denis-anisimov closed 5 years ago

denis-anisimov commented 5 years ago

Fixes #17

This change is Reviewable

vaadin-bot commented 5 years ago

SonarQube analysis reported 3 issues

Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

  1. MINOR TimePickerView.java#L207: Reorder the modifiers to comply with the Java Language Specification. rule
  2. MINOR TimePickerView.java#L210: Make this value-based field transient so it is not included in the serialization of this class. rule
  3. MINOR TimePickerView.java#L211: Make this value-based field transient so it is not included in the serialization of this class. rule
pleku commented 5 years ago

Actually, this is not enough. The user can also clear the input and press enter or just click somewhere else in the UI, and it will explode.

Please add the null check @denis-anisimov

denis-anisimov commented 5 years ago

Looks like Combobox is quite buggy. Textfield input should be used to filter the content since it's not allowed to enter custom values. And it works as it supposed if I type "a" and press Enter. Don't see any reason why it should work differently for an empty string. I will create a ticket for Combobox . The demo needs a workaround.