search

vaadin / vaadin-time-picker-flow

Vaadin Flow Java API for vaadin/vaadin-time-picker Web Component
https://vaadin.com/components/vaadin-time-picker
Other
6 stars 11 forks source link

Add clear button visible API, update min/max and add tests, demo #37

Closed yuriy-fix closed 5 years ago

yuriy-fix commented 5 years ago

Fixes #36

This change is Reviewable

CLAassistant commented 5 years ago

CLA assistant check
All committers have signed the CLA.

vaadin-bot commented 5 years ago

SonarQube analysis reported 5 issues

Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

  1. MINOR TimePickerView.java#L226: Reorder the modifiers to comply with the Java Language Specification. rule
  2. MINOR TimePickerView.java#L229: Make this value-based field transient so it is not included in the serialization of this class. rule
  3. MINOR TimePickerView.java#L230: Make this value-based field transient so it is not included in the serialization of this class. rule
  4. MINOR TimePicker.java#L47: Remove useless curly braces around statement and then remove useless return keyword rule
  5. MINOR TimePicker.java#L52: Remove useless curly braces around statement and then remove useless return keyword rule