vaadin / vaadin-time-picker-flow

Vaadin Flow Java API for vaadin/vaadin-time-picker Web Component
https://vaadin.com/components/vaadin-time-picker
Other
6 stars 11 forks source link

Improve error handling in connector: wrap with try catch #51

Closed yuriy-fix closed 4 years ago

yuriy-fix commented 5 years ago

Connected to https://github.com/vaadin/components-team-tasks/issues/479


This change is Reviewable

tomivirkki commented 5 years ago

Is there technically a way to have a shared tryCatchWrapper for all the components?

Should this be added to Flow directly, instead of repeating the same code in every connector? @pleku?

yuriy-fix commented 4 years ago

@Haprog, thanks for good suggestions! I was trying to avoid direct wrapping of i18n functions with tryCatchWrapper and instead wrap the relative methods in order not to mess-up those with wrappers from other components on the page when debugging.

But actually it makes sense, updated in latest commit.