search

vaadin / vaadin-time-picker-flow

Vaadin Flow Java API for vaadin/vaadin-time-picker Web Component
https://vaadin.com/components/vaadin-time-picker
Other
6 stars 11 forks source link

Server side validation #54

Closed tulioag closed 5 years ago

tulioag commented 5 years ago

This change is Reviewable

CLAassistant commented 5 years ago

CLA assistant check
All committers have signed the CLA.

CLAassistant commented 5 years ago

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

vaadin-bot commented 5 years ago

SonarQube analysis reported 6 issues

Watch the comments in this conversation to review them.

4 extra issues

Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

  1. MINOR TimePicker.java#L50: Remove useless curly braces around statement and then remove useless return keyword rule
  2. MINOR TimePicker.java#L55: Remove useless curly braces around statement and then remove useless return keyword rule
  3. MINOR TimePicker.java#L328: Remove this use of "executeJavaScript"; it is deprecated. rule
  4. MINOR TimePicker.java#L376: Remove this use of "callFunction"; it is deprecated. rule