search

vaadin / vaadin-time-picker-flow

Vaadin Flow Java API for vaadin/vaadin-time-picker Web Component
https://vaadin.com/components/vaadin-time-picker
Other
6 stars 11 forks source link

#55 Change min & max to LocalTime. #57

Closed sahalsaad closed 4 years ago

sahalsaad commented 5 years ago

This change is Reviewable

tomivirkki commented 5 years ago

Thanks for the PR. This is a breaking change as it is though. Please deprecate the existing APIs instead of removing them so this can be released as a new minor version.

sahalsaad commented 5 years ago

@tomivirkki I changed to deprecated. Thanks

sahalsaad commented 4 years ago

This PR is updated . @pekam

vaadin-bot commented 4 years ago

SonarQube analysis reported 15 issues

Watch the comments in this conversation to review them.

Top 10 extra issues

Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

  1. MINOR TimePickerView.java#L228: Reorder the modifiers to comply with the Java Language Specification. rule
  2. MINOR TimePickerView.java#L231: Make this value-based field transient so it is not included in the serialization of this class. rule
  3. MINOR TimePickerView.java#L232: Make this value-based field transient so it is not included in the serialization of this class. rule
  4. MINOR TimePickerView.java#L267: Remove this use of "executeJavaScript"; it is deprecated. rule
  5. MINOR TimePickerView.java#L271: Remove this use of "executeJavaScript"; it is deprecated. rule
  6. MINOR TimePicker.java#L50: Remove useless curly braces around statement and then remove useless return keyword rule
  7. MINOR TimePicker.java#L55: Remove useless curly braces around statement and then remove useless return keyword rule
  8. MINOR TimePicker.java#L65: Make this value-based field transient so it is not included in the serialization of this class. rule
  9. MINOR TimePicker.java#L66: Make this value-based field transient so it is not included in the serialization of this class. rule
  10. MINOR TimePicker.java#L333: Remove this use of "executeJavaScript"; it is deprecated. rule