search

vaadin / vaadin-time-picker-flow

Vaadin Flow Java API for vaadin/vaadin-time-picker Web Component
https://vaadin.com/components/vaadin-time-picker
Other
6 stars 11 forks source link

Implement FieldValidationUtil, add tests #60

Closed yuriy-fix closed 4 years ago

yuriy-fix commented 4 years ago

Fixes https://github.com/vaadin/vaadin-time-picker-flow/issues/59

This change is Reviewable

vaadin-bot commented 4 years ago

SonarQube analysis reported 7 issues

Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

  1. MINOR GeneratedVaadinTimePicker.java#L26: Remove this unused import 'com.vaadin.flow.component.Synchronize'. rule
  2. MINOR TimePicker.java#L50: Remove useless curly braces around statement and then remove useless return keyword rule
  3. MINOR TimePicker.java#L55: Remove useless curly braces around statement and then remove useless return keyword rule
  4. MINOR TimePicker.java#L65: Make this value-based field transient so it is not included in the serialization of this class. rule
  5. MINOR TimePicker.java#L66: Make this value-based field transient so it is not included in the serialization of this class. rule
  6. MINOR TimePicker.java#L333: Remove this use of "executeJavaScript"; it is deprecated. rule
  7. MINOR TimePicker.java#L381: Remove this use of "callFunction"; it is deprecated. rule