search

vaadin / vaadin-time-picker-flow

Vaadin Flow Java API for vaadin/vaadin-time-picker Web Component
https://vaadin.com/components/vaadin-time-picker
Other
6 stars 11 forks source link

Fix setMin/setMax when called with null #62

Closed DiegoCardoso closed 4 years ago

DiegoCardoso commented 4 years ago

Check for null on the argument before passing it to LocalTime#parse. Add tests for this case.

Fixes #61

claassistantio commented 4 years ago

CLA assistant check
All committers have signed the CLA.

claassistantio commented 4 years ago

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

vaadin-bot commented 4 years ago

SonarQube analysis reported 6 issues

Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

  1. MINOR TimePicker.java#L50: Remove useless curly braces around statement and then remove useless return keyword rule
  2. MINOR TimePicker.java#L55: Remove useless curly braces around statement and then remove useless return keyword rule
  3. MINOR TimePicker.java#L65: Make this value-based field transient so it is not included in the serialization of this class. rule
  4. MINOR TimePicker.java#L66: Make this value-based field transient so it is not included in the serialization of this class. rule
  5. MINOR TimePicker.java#L333: Remove this use of "executeJavaScript"; it is deprecated. rule
  6. MINOR TimePicker.java#L381: Remove this use of "callFunction"; it is deprecated. rule