search

vaadin / vaadin-time-picker-flow

Vaadin Flow Java API for vaadin/vaadin-time-picker Web Component
https://vaadin.com/components/vaadin-time-picker
Other
6 stars 11 forks source link

Migrate to Flow 3.0 #67

Closed denis-anisimov closed 4 years ago

denis-anisimov commented 4 years ago

Part of vaadin/flow#7338

tomivirkki commented 4 years ago

Might also want to remove pom-bower-mode.xml and mention of "-Dvaadin.bowerMode" from README

denis-anisimov commented 4 years ago

Might also want to remove pom-bower-mode.xml and mention of "-Dvaadin.bowerMode" from README

Right, thanks. But it still has a dep to combo-box which is not migrated yet :(

vaadin-bot commented 4 years ago

SonarQube analysis reported 11 issues

Watch the comments in this conversation to review them.

10 extra issues

Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

  1. MINOR TimePickerView.java#L226: Reorder the modifiers to comply with the Java Language Specification. rule
  2. MINOR TimePickerView.java#L229: Make this value-based field transient so it is not included in the serialization of this class. rule
  3. MINOR TimePickerView.java#L230: Make this value-based field transient so it is not included in the serialization of this class. rule
  4. MINOR TimePicker.java#L48: Remove useless curly braces around statement and then remove useless return keyword rule
  5. MINOR TimePicker.java#L53: Remove useless curly braces around statement and then remove useless return keyword rule
  6. MINOR TimePicker.java#L63: Make this value-based field transient so it is not included in the serialization of this class. rule
  7. INFO TimePicker.java#L412: Do not forget to remove this deprecated code someday. rule
  8. INFO TimePicker.java#L440: Do not forget to remove this deprecated code someday. rule
  9. INFO TimePicker.java#L467: Do not forget to remove this deprecated code someday. rule
  10. INFO TimePicker.java#L495: Do not forget to remove this deprecated code someday. rule