search

vaadin / vaadin-time-picker-flow

Vaadin Flow Java API for vaadin/vaadin-time-picker Web Component
https://vaadin.com/components/vaadin-time-picker
Other
6 stars 11 forks source link

[2.0] Bump webcomponent dependency and fix tests #72

Closed Haprog closed 4 years ago

Haprog commented 4 years ago

Bump vaadin-time-picker web component dependency to v2.0.5 and fix tests.

There were some minor bugs in the tests and usage of ComboBox was adding unnecessary complexity to some tests. This removes all usage of extra ComboBoxes in ITs and replaces them with native <select>. This also converts the TimePickerIT test view to not use the demo view for testing anymore (though it still depends on one helper class from the demo).

After this is merged, I will do similar PRs to master and 2.1 to make the tests consistent. master already has the web component bumped.

alvarezguille commented 4 years ago

Looks like we can at least remove the dependency to vaadin-combo-box-testbench and the import of ComboBoxElement

vaadin-bot commented 4 years ago

SonarQube analysis reported 1 issue

Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

  1. MINOR GeneratedVaadinTimePicker.java#L26: Remove this unused import 'com.vaadin.flow.component.Synchronize'. rule