search

vaadin / vaadin-upload-flow

Vaadin Flow Java API for vaadin/vaadin-upload Web Component
https://vaadin.com/components/vaadin-upload
Other
7 stars 17 forks source link

fix an obvious error #133

Closed haiwan closed 5 years ago

haiwan commented 5 years ago

This change is Reviewable

CLAassistant commented 5 years ago

CLA assistant check
All committers have signed the CLA.

vaadin-bot commented 5 years ago

SonarQube analysis reported 4 issues

Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

  1. CRITICAL UploadView.java#L259: Refactor this code to not nest more than 3 if/for/while/switch/try statements. rule
  2. MAJOR UploadView.java#L244: Either log or rethrow this exception. rule
  3. MAJOR UploadView.java#L270: Either log or rethrow this exception. rule
  4. MINOR UploadView.java#L271: Use a logger to log this exception. rule