Add file index to event details

vaadin / vaadin-upload

The Web Component for uploading multiple files with progress indication. Part of the Vaadin components.

https://vaadin.com/components

Apache License 2.0

90 stars 63 forks source link

Add file index to event details #290

Closed heruan closed 3 years ago

heruan commented 5 years ago

Fixes #289

This change is

CLAassistant commented 5 years ago

All committers have signed the CLA.

heruan commented 5 years ago

Not sure what's the status of this, changes were requested and applied; still, it needs some discussion (see review).

tomivirkki commented 5 years ago

Is there a need for such additional property? The files array is public so you can check the indexOf any file against that when the event occurs.

heruan commented 5 years ago

@tomivirkki I'm in a bit of a loop on this matter! Consider I'm using Flow, and I need the file index in the events dispatched by the Flow components, which in turn are filled with data from the JavaScript events (not to mention it also involves an interface from Flow core, see https://github.com/vaadin/vaadin-upload-flow/issues/100#issuecomment-440970541).

I'm not sure how to proceed to achieve this and I admit it feels difficult to contribute when the feature involves both the JavaScript and Java components which are two different repositories with different reviewers 😕

heruan commented 5 years ago

Any further feedback on this? It's been a while, but still the file index isn't available on the event 😕

web-padawan commented 3 years ago

It has been a while since this PR was submitted. Apologies about keeping it open for so long without any progress.

The component has been converted to Polymer 3 so there are merge conflicts. Also, the new development for Vaadin web components will happen in the monorepo.

I'm closing this now. We will submit a new PR to the monorepo when the linked issue is prioritised.