search

vaadin / web-components

A set of high-quality standards based web components for enterprise web applications. Part of Vaadin 20+
https://vaadin.com/docs/latest/components
436 stars 82 forks source link

[lumo] Monospace font family #1767

Open moderndeveloperllc opened 5 years ago

moderndeveloperllc commented 5 years ago

It looks like y'all are using a system stack for --lumo-font-family. I was hoping that y'all might implement a monospace system stack variable like --lumo-font-family-monospace. Currently there are a few stacks floating around.

Github:

font-family: "SFMono-Regular", Consolas, "Liberation Mono", Menlo, Courier, monospace;

Bootstrap 4:

font-family: SFMono-Regular, Menlo, Monaco, Consolas, "Liberation Mono", "Courier New", monospace;

This article points out some the the pros and cons to each.

jouni commented 5 years ago

Thanks! I do have this idea in my own backlog of improvements. I need to dump all of those in GitHub, should not harbor them in my own head.

I’ve added this font stack in my own notes as an alternative. Have to read the article you linked to learn more about the alternatives.

font-family: "SF Mono", "Segoe UI Mono", "Roboto Mono", "Ubuntu Mono", Menlo, Courier, monospace;
jouni commented 5 years ago

I’ve also been thinking about adding a “secondary font-family”, which could be used for headings, which would default to the main font-family.

moderndeveloperllc commented 4 years ago

Thanks! I do have this idea in my own backlog of improvements. I need to dump all of those in GitHub, should not harbor them in my own head.

I’ve added this font stack in my own notes as an alternative. Have to read the article you linked to learn more about the alternatives.

font-family: "SF Mono", "Segoe UI Mono", "Roboto Mono", "Ubuntu Mono", Menlo, Courier, monospace;

Those look to be good families. have you had a chance to play around on different OSs/browsers to see if they are all valid?

jouni commented 4 years ago

@moderndeveloperllc, no I haven’t really had any time to continue this research. I would expect that the stacks listed in the article perform better than the one I added in my comments.