vaadin / web-components

A set of high-quality standards based web components for enterprise web applications. Part of Vaadin 20+
https://vaadin.com/docs/latest/components
445 stars 83 forks source link

vaadin-select-value-button & aria-required #7337

Open anezthes opened 5 months ago

anezthes commented 5 months ago

Semantics issue.

<vaadin-select-value-button aria-required="true" role="button" ... >

The aria-required attribute is not meant for buttons. See aria-required - Accessibility | MDN.

web-padawan commented 5 months ago

Thanks for the issue. The attribute is set by FieldAriaController, which probably needs to be updated to check for role.