search

vaadin / web-components

A set of high-quality standards based web components for enterprise web applications. Part of Vaadin 20+
https://vaadin.com/docs/latest/components
470 stars 83 forks source link

refactor: make radio-group properties use sync updates in Lit #8127

Closed web-padawan closed 2 weeks ago

web-padawan commented 2 weeks ago

Description

Currently the Lit version breaks with read-only group where there is an infinite loop (as far as I understand it's related to calling rebuild()). Changing value property to use sync: true fixes that.

Note: I though that it makes sense to also update name and readonly so that the component works consistently in terms of updating radio buttons (as e.g. disabled property is already using sync as well as value).

Type of change

sonarcloud[bot] commented 2 weeks ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

vaadin-bot commented 5 days ago

This ticket/PR has been released with Vaadin 24.6.0.alpha4 and is also targeting the upcoming stable 24.6.0 version.