search

vaadin / web-components

A set of high-quality standards based web components for enterprise web applications. Part of Vaadin 20+
https://vaadin.com/docs/latest/components
470 stars 83 forks source link

feat: grid-pro loading editor state #8156

Closed tomivirkki closed 4 days ago

tomivirkki commented 1 week ago

Description

To resolve https://github.com/vaadin/web-components/issues/2550, add support to vaadin-grid-pro for loading-editor attribute, which disables keyboard interaction on the focused cell and styles it with a pulsating outline. Also, content of the cell is hidden (using opacity) and pointer events are prevented on it.

The following recording uses the Flow GridPro component with network throttling on.

https://github.com/user-attachments/assets/a1893997-3a31-4f82-9507-0a63cf294192

Related https://github.com/vaadin/flow-components/pull/6820

The feature is not intended for public use so it's not documented nor exposed as a property.

Part of https://github.com/vaadin/web-components/issues/2550

Type of change

Feature

sonarcloud[bot] commented 1 week ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

vaadin-bot commented 4 days ago

Hi @tomivirkki and @tomivirkki, when i performed cherry-pick to this commit to 24.4, i have encountered the following issue. Can you take a look and pick it manually? Error Message: Error: Command failed: git cherry-pick 6ef77b92d7470138315f4a587a64f338885a3c43 error: could not apply 6ef77b92d7... feat: grid-pro loading editor state (#8156) hint: After resolving the conflicts, mark them with hint: "git add/rm ", then run hint: "git cherry-pick --continue". hint: You can instead skip this commit with "git cherry-pick --skip". hint: To abort and get back to the state before "git cherry-pick", hint: run "git cherry-pick --abort".

vaadin-bot commented 4 days ago

Hi @tomivirkki and @tomivirkki, when i performed cherry-pick to this commit to 24.3, i have encountered the following issue. Can you take a look and pick it manually? Error Message: Error: Command failed: git cherry-pick 6ef77b92d7470138315f4a587a64f338885a3c43 error: could not apply 6ef77b92d7... feat: grid-pro loading editor state (#8156) hint: After resolving the conflicts, mark them with hint: "git add/rm ", then run hint: "git cherry-pick --continue". hint: You can instead skip this commit with "git cherry-pick --skip". hint: To abort and get back to the state before "git cherry-pick", hint: run "git cherry-pick --abort".

vaadin-bot commented 2 days ago

This ticket/PR has been released with Vaadin 24.6.0.alpha4 and is also targeting the upcoming stable 24.6.0 version.