vaadin / web-components

A set of high-quality standards based web components for enterprise web applications. Part of Vaadin 20+
https://vaadin.com/docs/latest/components
470 stars 83 forks source link

refactor: hide dashboard resize buttons that have no effect #8176

Closed tomivirkki closed 2 days ago

tomivirkki commented 3 days ago

Description

This change improves Dashboard UX by only showing a widget's resize-mode buttons that affect its column span/row span on click.

https://github.com/user-attachments/assets/8c66cfe0-ee22-4749-a445-17378472c41a

Fixes https://github.com/vaadin/web-components/issues/8152

Type of change

Refactor / UX

sonarcloud[bot] commented 3 days ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

ugur-vaadin commented 2 days ago

Should we still show the buttons that increase the colspan/rowspan even though that increase does not affect the visible content at that point?

tomivirkki commented 2 days ago

Should we still show the buttons that increase the colspan/rowspan even though that increase does not affect the visible content at that point?

It doesn't affect the colspan at all, even if you click it. That's by design.

vaadin-bot commented 22 hours ago

This ticket/PR has been released with Vaadin 24.6.0.beta1 and is also targeting the upcoming stable 24.6.0 version.