search

vaadin / web-components

A set of high-quality standards based web components for enterprise web applications. Part of Vaadin 20+
https://vaadin.com/docs/latest/components
470 stars 83 forks source link

fix: align prefix and suffix with textarea in Material theme #8189

Closed sissbruecker closed 2 days ago

sissbruecker commented 2 days ago

For Material theme, the prefix and suffix elements did not have a top margin, whereas the native textarea does. Which causes icons and text to be misaligned. This adds the same top margin to prefix elements to fix the alignment.

Bildschirmfoto 2024-11-20 um 12 33 18
sonarcloud[bot] commented 2 days ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

vaadin-bot commented 2 days ago

Hi @sissbruecker and @web-padawan, when i performed cherry-pick to this commit to 24.5, i have encountered the following issue. Can you take a look and pick it manually? Error Message: Error: Command failed: git cherry-pick c5232cb5ff0c20aff5fe926158017e9fbfd5a1a4 error: could not apply c5232cb5ff... fix: align prefix and suffix with textarea in Material theme (#8189) hint: After resolving the conflicts, mark them with hint: "git add/rm ", then run hint: "git cherry-pick --continue". hint: You can instead skip this commit with "git cherry-pick --skip". hint: To abort and get back to the state before "git cherry-pick", hint: run "git cherry-pick --abort".

vaadin-bot commented 22 hours ago

This ticket/PR has been released with Vaadin 24.6.0.beta1 and is also targeting the upcoming stable 24.6.0 version.