search

vaadin / web-components

A set of high-quality standards based web components for enterprise web applications. Part of Vaadin 20+
https://vaadin.com/docs/latest/components
470 stars 83 forks source link

refactor: include notification container into the overlay stack #8198

Closed web-padawan closed 1 day ago

web-padawan commented 1 day ago

Description

Fixes https://github.com/vaadin/flow-components/issues/6836

This is an alternative fix to #8193 as suggested in https://github.com/vaadin/web-components/pull/8193#discussion_r1851728422

Adding notification container to the common overlay stack resolves also the issue similar to the one reported in https://github.com/vaadin/web-components/issues/5748 but for vaadin-popover and other overlays that can be technically triggered from buttons inside the vaadin-notification.

Type of change

Note

We also have _enterModalState() method in the OverlayStackMixin - this method isn't called in case of notification container, so that it's still possible to interact with underlying vaadin-dialog when the notification is opened from it.

sonarcloud[bot] commented 1 day ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

web-padawan commented 1 day ago

The Firefox test is unrelated to the PR, I'm going to merge without requiring checks to pass.