search

vaadin / web-components

A set of high-quality standards based web components for enterprise web applications. Part of Vaadin 20+
https://vaadin.com/docs/latest/components
470 stars 83 forks source link

refactor!: align hasInputValue behavior across components #8200

Closed vursen closed 23 hours ago

vursen commented 1 day ago

Description

DatePicker and TimePicker counterparts have been recently updated to no longer rely on the hasInputValue property for detecting bad input. This removes the need for workarounds that caused the hasInputValue behavior to be inconsistent with other components

Fixes https://github.com/vaadin/web-components/issues/5639

Type of change

sonarcloud[bot] commented 1 day ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

vursen commented 1 day ago

LGTM. Maybe we could also deprecate _hasInputValue property and the corresponding event if it's not supposed to be used anymore. This can be done separately though.

NumberField still uses it, but we could likely refactor it, which will remove the last dependency and let us deprecate this property.