search

vaadin / web-components

A set of high-quality standards based web components for enterprise web applications. Part of Vaadin 20+
https://vaadin.com/docs/latest/components
470 stars 83 forks source link

test: activate cell with Enter instead of double click #8202

Closed web-padawan closed 1 day ago

web-padawan commented 1 day ago

Description

Looks like using Enter instead of double click to activate the cell is more reliable.

Type of change

tomivirkki commented 1 day ago

I've noticed this flakiness (same tests) on Chrome too, not as often as on FF though

EDIT: Oh it happened with this PR also :)

web-padawan commented 1 day ago

Right, that's problematic... I'll try to investigate this a bit more. It could be that these tests have been flaky since I changed them to use sendKeys() in https://github.com/vaadin/web-components/pull/7822 although initially they didn't seem to fail that often.

web-padawan commented 1 day ago

Using Enter to activate the cell locally seems to work, let's see if this passes in CI.

sonarcloud[bot] commented 1 day ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud