[time-picker] i18n.formatTime and .parseTime are called multiple times unnecessarily - Githubissues

vaadin / web-components

A set of high-quality standards based web components for enterprise web applications. Part of Vaadin 20+

https://vaadin.com/docs/latest/components

454 stars 83 forks source link

[time-picker] i18n.formatTime and .parseTime are called multiple times unnecessarily #888

Open pleku opened 5 years ago

pleku commented 5 years ago

After returning a valid object from i18n.parseTime function after end user input

the parseTime is called in total 2-3 times, depending on whether or the user has entered 1-1 value matching the drop down or not
the formatTime is called also multiple times if the input value does not match fully of something in the drop down

After returning a valid object from i18n.parseTime function after user selects a value from the drop down

the formatTime is called twice with the same paramater second time unnecessarily

These don't cause much overhead probably, but is still very weird since it is just unnecessary and the return values are the same

yuriy-fix commented 5 years ago

Requires refactoring of the webcomponent. Will be done later.