search

vaakash / git-it-write

A WordPress plugin to publish markdown files present in a Github repository as posts to WordPress automatically.
https://www.aakashweb.com/wordpress-plugins/git-it-write/
GNU General Public License v3.0
45 stars 22 forks source link

Fix issue #2 on duplicate posts #10

Closed fullbright closed 1 year ago

fullbright commented 2 years ago

Compair the slug from github with the one stored in wordpress post meta.

fullbright commented 2 years ago

Fix the issue #8 for myself. Wanted to share it.

lukaszpiotrluczak commented 1 year ago

@vaakash this PR contains some good ideas. Maybe I can resolve conflicts and polish it so that this changes can be included in next release?

vaakash commented 1 year ago

@lukaszpiotrluczak Sure, please do submit PR. Uploading featured image is one of the requested featured. I believe that is the only feature which can be pulled from this PR.

fullbright commented 1 year ago

Merge has been done. I couldn't test. If some one can help with testing, that would be nice.

vaakash commented 1 year ago

Hi @fullbright, Thanks for the changes. The issue where duplicate posts were published is addressed in v1.4 - https://github.com/vaakash/git-it-write/releases/tag/v1.4 already.

Also, this PR is lagging behind. I think we can close this PR and review a fresh one.

For the changes related to uploading featured image, can you please submit a new PR?

lukaszpiotrluczak commented 1 year ago

Hi @fullbright, I also think we could close this PR. If you want to provide a new PR with featured image then great! And if you don't want to then I can provide it. Just please give a note. Best regards Łukasz

fullbright commented 1 year ago

Hello,

Sorry for the late reply. Okay. I let you provide it. My idea was to provide a way to set the image from an external url, as well as with an image in the repo.

Thank you.

Le mer. 14 déc. 2022 à 23:29, Łukasz Piotr Łuczak @.***> a écrit :

Hi @fullbright https://github.com/fullbright, I also think we could close this PR. If you want to provide a new PR with featured image then great! And if you don't want to then I can provide it. Just please give a note. Best regards Łukasz

— Reply to this email directly, view it on GitHub https://github.com/vaakash/git-it-write/pull/10#issuecomment-1352307233, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAF476GGVT5FW7BEQRSKLW3WNJC4HANCNFSM5XGTZQAQ . You are receiving this because you were mentioned.Message ID: @.***>