search

vacanza / holidays

World Holidays Framework
https://pypi.org/project/holidays
MIT License
1.46k stars 462 forks source link

2 Missing UK Bank holidays #1449

Closed will-judge closed 1 year ago

will-judge commented 1 year ago

There are normally 8 bank holidays in the UK each year (https://www.gov.uk/bank-holidays), whilst holidays.CountryHoliday("UnitedKingdom", years=2023) lists 6 regulars bank holidays.

The missing bank holidays are the "Summer bank holiday" and the "Easter Monday bank holiday". This error occurs in both 2023 and 2024.

KJhellico commented 1 year ago

@will-judge, thank you for your comments and useful source! These holidays (Easter Monday and Late Summer Bank Holiday) are not common to the entire United Kingdom, but only to England, Wales and Northern Ireland (they are not holidays in Scotland). So you may find them in something like holidays.CountryHoliday("UK", subdiv="ENG", years=2023) (also "NIR" or "WLS" instead of "ENG").

arkid15r commented 1 year ago

Yeah, I was just going to reply with pretty much the same code example. The UK holidays implementation was revamped recently (see https://github.com/vacanza/python-holidays/pull/1316)

I hope this helps.

arkid15r commented 1 year ago

I believe this can be closed.