search

vacanza / holidays

World Holidays Framework
https://pypi.org/project/holidays
MIT License
1.48k stars 467 forks source link

Verify SE holiday calendar #1654

Open arkid15r opened 9 months ago

arkid15r commented 9 months ago

SE has every Saturday included as a public holiday, even though only the banks are closed. Is this intended? If so it is at least misleading as BANK is not the primary category if I understand it correctly.

Originally posted by @nick2202 in https://github.com/vacanza/python-holidays/issues/1646#issuecomment-1903926225

KJhellico commented 9 months ago

Actually, it's every Sunday we have as public holiday (with special arg include_sundays=True). I've always wondered how Sundays in Sweden differ from Sundays in other countries (where they are also days off). As far as I understood, the reason for this difference is that

In Sweden, public holidays are defined in the Swedish Constitution as a Sunday, or another day in a list of public holidays

(from Wiki, machine translation to English)

Is this a enough reason for us to include all Sundays in the list of holidays? Maybe we could at least set include_sundays default value to False? (exactly how it's done for Norway now)

PPsyrius commented 3 weeks ago

Have we ever reached a conclusion on this?

arkid15r commented 3 weeks ago

Have we ever reached a conclusion on this?

It doesn't seem so. I'd like to change the Sundays situation for SE in v1 but before that it'd be great to have some input from users familiar with the context.

I'd keep it as is for v0 unless someone has strong reasons for opposite.