Update Costa Rica holidays - Githubissues

vacanza / holidays

Generate and work with holidays in Python

https://pypi.org/project/holidays

MIT License

1.45k stars 460 forks source link

Update Costa Rica holidays #1657

Closed KJhellico closed 8 months ago

KJhellico commented 8 months ago

Proposed change

Update Costa Rica holidays:

move some holidays to OPTIONAL category
fix May 1 holiday en_US translation
refactor tests

Type of change

[ ] New country/market holidays support (thank you!)
[x] Supported country/market holidays update (calendar discrepancy fix, localization)
[ ] Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
[ ] Dependency update (version deprecation/upgrade)
[ ] Bugfix (non-breaking change which fixes an issue)
[ ] Breaking change (a code change causing existing functionality to break)
[ ] New feature (new python-holidays functionality in general)

Checklist

[x] I've followed the contributing guidelines
[x] I've run make pre-commit, it didn't generate any changes
[x] I've run make test, all tests passed locally

sonarcloud[bot] commented 8 months ago

Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

9 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

coveralls commented 8 months ago

Pull Request Test Coverage Report for Build 7629028448

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals
Change from base Build 7591701254:	0.0%
Covered Lines:	10278
Relevant Lines:	10278

💛 - Coveralls