Unify common holidays name translation

KJhellico commented 8 months ago

Proposed change

Unify common holidays name translation (step to switch to per-locale .po files):

unify en_US translation of Labor Day, Christmas Day, Assumption Day, Easter Sunday etc.
update comments

Type of change

[ ] New country/market holidays support (thank you!)
[x] Supported country/market holidays update (calendar discrepancy fix, localization)
[ ] Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
[ ] Dependency update (version deprecation/upgrade)
[ ] Bugfix (non-breaking change which fixes an issue)
[ ] Breaking change (a code change causing existing functionality to break)
[ ] New feature (new python-holidays functionality in general)

Checklist

[x] I've followed the contributing guidelines
[x] I've run make pre-commit, it didn't generate any changes
[x] I've run make test, all tests passed locally

coveralls commented 8 months ago

Pull Request Test Coverage Report for Build 7694471159

0 of 12 (100.0%) changed or added relevant lines in 5 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals
Change from base Build 7689599421:	0.0%
Covered Lines:	10424
Relevant Lines:	10424

💛 - Coveralls

KJhellico commented 8 months ago

Yes, for some Islamic holidays we use here "traditional" version of the name rather than translated one. Where Eid al-Fitr and Eid al-Adha can still be translated (as "Feast of Breaking the Fast" and "Feast of Sacrifice"), I can't find a suitable short name for Isra' and Mi'raj and Ashura, for example :)

sonarcloud[bot] commented 8 months ago

Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

vacanza / holidays