vacanza / holidays

Generate and work with holidays in Python
https://pypi.org/project/holidays
MIT License
1.45k stars 460 forks source link

Australia NSW - Bank Holiday only within Holiday data #1674

Closed Ghawken closed 6 months ago

Ghawken commented 8 months ago

Hi

Well done on maintaining library!

Further to the original request, which I see has been closed, this 5th August Subdiv=NSW Australia Holiday remains.

This 1st Monday August entry here: Code Link - Australia.py

australia.py

    def _populate_subdiv_nsw_public_holidays(self):
        # Easter
        self._add_holy_saturday("Easter Saturday")
        self._add_easter_sunday("Easter Sunday")

        # Labour Day
        self._add_holiday_1st_mon_of_oct("Labour Day")

        # Sovereign's Birthday
        if self._year >= 1936:
            self._add_holiday_2nd_mon_of_jun(self.sovereign_birthday)

        # Bank Holiday
        if self._year >= 1912:
            self._add_holiday_1st_mon_of_aug("Bank Holiday")

This Bank Holiday one…

NSW Public Holidays

(It is referenced here - but with caveat only applies to Bank workers.)

It is a ‘Bank employee’ only holiday and not a public holiday for the vast majority of population.

? Seems to be misreported still currently in 0.41

It could be removed, in my mind altogether, OR have add a new category for bank for AU added- and include this current entry as a bank only holiday?

Thanks for reviewing.

Originally posted by @Ghawken in https://github.com/vacanza/python-holidays/issues/293#issuecomment-1913361627