search

vacanza / holidays

Generate and work with holidays in Python
https://pypi.org/project/holidays
MIT License
1.45k stars 460 forks source link

[development] `make l10n` command is broken #1727

Closed PPsyrius closed 6 months ago

PPsyrius commented 7 months ago

make l10n command has been broken since commit 00482f669fabc10083319d658237ae109a689f35 ( #1724 ).

KJhellico commented 7 months ago

I have no problems with this (on Windows). But I always run

python scripts/l10n/generate_po_files.py

because if I try to run script without python, it doesn't see installed external packages in my environment. But it was always like that, and I got used to it. :) BTW, do you have our new lingva package installed?

arkid15r commented 7 months ago

make l10n command has been broken since commit 00482f669fabc10083319d658237ae109a689f35 ( #1724 ).

What's your scripts/l10n/generate_po_files.py run output?

PPsyrius commented 7 months ago

make l10n command has been broken since commit 00482f669fabc10083319d658237ae109a689f35 ( #1724 ).

What's your scripts/l10n/generate_po_files.py run output?

For context, I usually ran make l10n and make snapshot on WIndows' WSL mode (Ubuntu 22.04), here's the result I got for make l10n

ppsyrius@[redacted]:/mnt/d/[redacted]/python-holidays$ make l10n

scripts/l10n/generate_po_files.py >/dev/null 2>&1
make: *** [Makefile:35: l10n] Error 1
arkid15r commented 6 months ago

Try make setup first. If that doesn't help, run scripts/l10n/generate_po_files.py (without stdout/stderr redirect) and paste the error here.

arkid15r commented 6 months ago

@PPsyrius have you resolved this?

PPsyrius commented 6 months ago

@arkid15r Yes, make setup gets make l10n work again - thanks for the help :)