Add file header pre-commit check - Githubissues

vacanza / holidays

Generate and work with holidays in Python

https://pypi.org/project/holidays

MIT License

1.45k stars 460 forks source link

Add file header pre-commit check #1744

Closed arkid15r closed 6 months ago

arkid15r commented 6 months ago

Proposed change

I extended the file header inclusion to .po files and added a pre-commit check to keep it consistent. The AUTHORS file was also updated based on the removed authors comments from the .po files.

Type of change

[ ] New country/market holidays support (thank you!)
[ ] Supported country/market holidays update (calendar discrepancy fix, localization)
[x] Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
[ ] Dependency update (version deprecation/upgrade)
[ ] Bugfix (non-breaking change which fixes an issue)
[ ] Breaking change (a code change causing existing functionality to break)
[ ] New feature (new python-holidays functionality in general)

Checklist

[x] I've followed the contributing guidelines
[x] I've run make pre-commit, it didn't generate any changes
[x] I've run make test, all tests passed locally

coveralls commented 6 months ago

Pull Request Test Coverage Report for Build 8483733589

Details

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals
Change from base Build 8472267167:	0.0%
Covered Lines:	10968
Relevant Lines:	10968

💛 - Coveralls

sonarcloud[bot] commented 6 months ago

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud