vacanza / holidays

Generate and work with holidays in Python
https://pypi.org/project/holidays
MIT License
1.45k stars 460 forks source link

Add Jordan holidays #1746

Closed firaskafri closed 6 months ago

firaskafri commented 6 months ago

Proposed change

Added Jordan (Country) to supported countries.

Type of change

Checklist

coveralls commented 6 months ago

Pull Request Test Coverage Report for Build 8541663992

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details


Totals Coverage Status
Change from base Build 8516352184: 0.0%
Covered Lines: 10997
Relevant Lines: 10997

💛 - Coveralls
arkid15r commented 6 months ago

@abh31000, could you review this when you get a chance?

Thank you!

firaskafri commented 6 months ago

Hey @arkid15r @abh31000 !

Thank you for the review, all addressed now.

firaskafri commented 6 months ago

thank you @KJhellico , all fixed. Thanks!

sonarcloud[bot] commented 6 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud