Update Eid al-Fitr 2024 dates - Githubissues

vacanza / holidays

Generate and work with holidays in Python

https://pypi.org/project/holidays

MIT License

1.45k stars 460 forks source link

Update Eid al-Fitr 2024 dates #1758

Closed KJhellico closed 6 months ago

KJhellico commented 6 months ago

Proposed change

Update Eid-al-Fitr 2024 date (set exact date to April 10).

Type of change

[ ] New country/market holidays support (thank you!)
[x] Supported country/market holidays update (calendar discrepancy fix, localization)
[ ] Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
[ ] Dependency update (version deprecation/upgrade)
[ ] Bugfix (non-breaking change which fixes an issue)
[ ] Breaking change (a code change causing existing functionality to break)
[ ] New feature (new python-holidays functionality in general)

Checklist

[x] I've followed the contributing guidelines
[x] I've run make pre-commit, it didn't generate any changes
[x] I've run make test, all tests passed locally

sonarcloud[bot] commented 6 months ago

Quality Gate failed

Failed conditions
7.0% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

coveralls commented 6 months ago

Pull Request Test Coverage Report for Build 8617218600

Details

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals
Change from base Build 8602503496:	0.0%
Covered Lines:	11003
Relevant Lines:	11003

💛 - Coveralls