Extend HolidayBase::_add_holiday family methods with Easter support - Githubissues

vacanza / holidays

Generate and work with holidays in Python

https://pypi.org/project/holidays

MIT License

1.45k stars 460 forks source link

Extend HolidayBase::_add_holiday family methods with Easter support #1762

Closed KJhellico closed 5 months ago

KJhellico commented 5 months ago

Proposed change

Add _add_holiday_N_days_past_easter() and _add_holiday_N_days_prior_easter() patterns support.

Type of change

[ ] New country/market holidays support (thank you!)
[ ] Supported country/market holidays update (calendar discrepancy fix, localization)
[x] Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
[ ] Dependency update (version deprecation/upgrade)
[ ] Bugfix (non-breaking change which fixes an issue)
[ ] Breaking change (a code change causing existing functionality to break)
[ ] New feature (new python-holidays functionality in general)

Checklist

[x] I've followed the contributing guidelines
[x] I've run make pre-commit, it didn't generate any changes
[x] I've run make test, all tests passed locally

coveralls commented 5 months ago

Pull Request Test Coverage Report for Build 8710463921

Details

25 of 25 (100.0%) changed or added relevant lines in 14 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals
Change from base Build 8693825960:	0.0%
Covered Lines:	11004
Relevant Lines:	11004

💛 - Coveralls

sonarcloud[bot] commented 5 months ago

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud