Refactor `HolidayBase::__getattr__`: speed up _add_holiday_* methods

KJhellico commented 5 months ago

Proposed change

Refactor HolidayBase::__getattr__: speed up _addholiday* methods (remove regex use).

Test script result:

regex = 8.577 no regex = 2.879 (5000 times)

Type of change

[ ] New country/market holidays support (thank you!)
[ ] Supported country/market holidays update (calendar discrepancy fix, localization)
[x] Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
[ ] Dependency update (version deprecation/upgrade)
[ ] Bugfix (non-breaking change which fixes an issue)
[ ] Breaking change (a code change causing existing functionality to break)
[ ] New feature (new python-holidays functionality in general)

Checklist

[x] I've followed the contributing guidelines
[x] I've run make pre-commit, it didn't generate any changes
[x] I've run make test, all tests passed locally

coveralls commented 5 months ago

Pull Request Test Coverage Report for Build 8851034115

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.