vacanza / holidays

Generate and work with holidays in Python
https://pypi.org/project/holidays
MIT License
1.45k stars 460 forks source link

Update Hong Kong holidays #1767

Closed KJhellico closed 4 months ago

KJhellico commented 5 months ago

Proposed change

Update Hong Kong holidays (massive rewrite, actually).

Type of change

Checklist

coveralls commented 5 months ago

Pull Request Test Coverage Report for Build 9082675051

Details


Totals Coverage Status
Change from base Build 9025569154: 0.0%
Covered Lines: 11164
Relevant Lines: 11164

💛 - Coveralls
PPsyrius commented 5 months ago

@KJhellico I don't think this is the intended behaviour here: image image

KJhellico commented 5 months ago
  1. Yes, now snapshot looks incorrect in the part of displaying observed holidays. I'm working on it.
  2. According to Wiki

1983年起,英女皇壽辰假期由4月21日改為英國官方慶祝日6月第二個星期六,而之後的星期一亦放假。

I translated it as

Since 1983, the Queen's birthday holiday has been changed from April 21 to the second Saturday in June, the official British celebration day, and the following Monday is also a holiday.

That's why Queen's Birthday holiday looks like this. If I'm wrong, please correct me.

KJhellico commented 5 months ago

Now, with #1769 merged, snapshot looks more realistic.

sonarcloud[bot] commented 4 months ago

Quality Gate Passed Quality Gate passed

Issues
3 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud