vacanza / holidays

Generate and work with holidays in Python
https://pypi.org/project/holidays
MIT License
1.45k stars 460 forks source link

Update observed rules: add holiday removal support #1796

Closed arkid15r closed 4 months ago

arkid15r commented 4 months ago

Proposed change

This PR extends our ObservedRule class to support "move to None" cases. In other words it's a holiday removal (no holiday + no observance type of rule). I've got this idea while reviewing https://github.com/vacanza/python-holidays/pull/1792, specifically from this comment. It'll be useful for making IFEU holiday calendar a bit cleaner.

Let me know your thoughts on this when you get a chance.

P.S. I did my best to avoid naming the rule ???_TO_NONDAY :)

Type of change

Checklist

sonarcloud[bot] commented 4 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.1% Duplication on New Code

See analysis details on SonarCloud

coveralls commented 4 months ago

Pull Request Test Coverage Report for Build 9130851431

Details


Totals Coverage Status
Change from base Build 9099445825: 0.0%
Covered Lines: 11169
Relevant Lines: 11169

💛 - Coveralls