Closed arkid15r closed 4 months ago
Issues
0 New issues
0 Accepted issues
Measures
0 Security Hotspots
No data about Coverage
0.1% Duplication on New Code
Totals | |
---|---|
Change from base Build 9099445825: | 0.0% |
Covered Lines: | 11169 |
Relevant Lines: | 11169 |
Proposed change
This PR extends our
ObservedRule
class to support "move to None" cases. In other words it's a holiday removal (no holiday + no observance type of rule). I've got this idea while reviewing https://github.com/vacanza/python-holidays/pull/1792, specifically from this comment. It'll be useful for makingIFEU
holiday calendar a bit cleaner.Let me know your thoughts on this when you get a chance.
P.S. I did my best to avoid naming the rule
???_TO_NONDAY
:)Type of change
Checklist
make pre-commit
, it didn't generate any changesmake test
, all tests passed locally